Skip to content

Update eval.{txt,jax} #2271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update eval.{txt,jax} #2271

wants to merge 5 commits into from
+110 −71

Conversation

h-east
Copy link
Member

@h-east h-east commented Aug 24, 2025

No description provided.

mityu
mityu approved these changes Aug 25, 2025
View reviewed changes
Copy link
Member

@mityu mityu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一箇所だけ、こうした方が読みやすいかなあというのがあったので提案を書いてますが、全体としては LGTM なので approve します。

mityu
mityu reviewed Aug 30, 2025
View reviewed changes
Copy link
Member

@mityu mityu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

まだ更新分の差分を見れていないんですが、とりあえずCIが落ちている分だけ直しました

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mityu mityu mityu approved these changes

@tsuyoshicho tsuyoshicho tsuyoshicho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@h-east @tsuyoshicho @mityu